Messages in this thread |  | | | Date | Mon, 7 Mar 2011 20:25:07 +0100 | | Subject | Re: [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function. | | From | Belisko Marek <> |
| |
On Mon, Mar 7, 2011 at 4:55 PM, Dan Carpenter <error27@gmail.com> wrote: > On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote: >> - if (urb->status) >> - printk("%s: TX status %d\n", ft1000dev->net->name, urb->status); >> + if (urb->status) >> + DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status); >> > > Why did you change the printk() to a DEBUG()? That's a behavior change, > and it should have been mentioned in the commit message. Mea culpa. checkpatch.pl complain about no KERN_... prefix so just fix with replace to DEBUG. Will return back to printk. @Greg: should resend whole serie or just this patch? > > regards, > dan carpenter > >> - netif_wake_queue(ft1000dev->net); >> + netif_wake_queue(ft1000dev->net); >> >> //DEBUG("Return from ft1000_usb_transmit_complete\n"); >> } > >
thansk,
marek
-- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |