Messages in this thread | | | Date | Sat, 5 Mar 2011 21:30:40 +0100 | From | Oleg Nesterov <> | Subject | [PATCH v4 0/4] exec: unify native/compat code |
| |
On 03/03, Linus Torvalds wrote: > > On Thu, Mar 3, 2011 at 7:47 AM, Oleg Nesterov <oleg@redhat.com> wrote: > >> I _personally_ don't like "conditional". Its name is based on code logic. > >> It's unclear what mean "conditional". From data strucuture view, It is > >> "opaque userland pointer". > > > > I agree with any naming, just suggest a better name ;) > > Maybe just "struct user_arg_ptr" or something?
OK, nothing else was suggessted, I assume Kosaki agrees.
So rename conditional_ptr to user_arg_ptr.
Also rename get_user_ptr() to get_user_arg_ptr(). It was suggested to use the same "user_arg_ptr" for this helper too, but this is not grep-friendly. As for get_ in the name... Well, I can redo again ;) But this matches get_user() and this is all what this helper does.
Otherwise unchanged.
Oleg.
| |