lkml.org 
[lkml]   [2011]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2] x86: early_quirk check all bus/dev/func in domain 0
On Mon, 07 Feb 2011 14:14:52 -0800
Yinghai Lu <yinghai@kernel.org> wrote:

>
> When we have 00:1a.0, 00:1a.1, 00:1a.2, 00:1a.7
> Found only 00:1a.0, and 00:1a.1 get processed. and 00:1a.2 and 00:1a.7 get skipped.
>
> We should only check header type on func0.
> Also should not bail out when have gap.
>
> At last try to process bus 00 - 0xff instead of only bus 00.
>
> -v2: check with VENDOR_ID instead of CLASS_DEVICE for invalid device.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

I need a much better changelog here. It sounds (and looks) like the
patch is doing several things:
- processing more than the first two functions on a device
- processing the full set of busses in the first domain
- checking for nonexistent devices

Why are you making these changes? Do you have a system that needs
early quirks but violates the existing assumptions? Can you apply a
standard quirk instead?

--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2011-03-06 11:19    [W:0.095 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site