Messages in this thread | | | Subject | Re: [PATCH 0/4] use BUG_ON correctly, v4 | From | "Koul, Vinod" <> | Date | Thu, 31 Mar 2011 11:14:26 +0530 |
| |
On Sun, 2011-03-27 at 01:26 +0800, Coly Li wrote: > Most of BUG_ON() implementations use unlikely() internally for better > branch prediction results. The following method to use BUG_ON() with > an explicit unlikely() doesn't make things better and is unwelcome: > BUG_ON(unlikely(condition)); > Source code should use BUG_ON() just with condition code. > > For arch implementation of BUG_ON(), there are feed backs for v2 patch > set from MIPS and PowerPC developers than neither explicit no implicit > unlikely() does help anything. > > Therefore using unlikely() explicit with BUG_ON() is always a bug. This > patch set removes all incorrect BUG_ON() usage. > > Patch "Staging: wl_cfg80211.c: use BUG_ON correctly" is merged into > upstream (commit d7ddd169), no longer in v4 patch set. For v4 > patch set, proper maintainers are added into Cc list by the help of > scripts/get_maintainer.pl. > > Cc: Greg KH <gregkh@suse.de> > Cc: Yong Zhang <yong.zhang0@gmail.com> > Cc: Wang Cong <xiyou.wangcong@gmail.com> > Signed-off-by: Coly Li <bosong.ly@taobao.com> > --- > drivers/dma/iop-adma.c | 6 +++--- > drivers/dma/mv_xor.c | 6 +++--- > drivers/dma/ppc4xx/adma.c | 8 ++++---- > drivers/scsi/scsi_lib.c | 4 ++-- > 4 files changed, 12 insertions(+), 12 deletions(-) Thanks, Applied first 3 patches. 4th one should go to scsi folks. It would help if you can split patch series per subsystem.
-- ~Vinod
| |