Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 31/36] security,rcu: convert call_rcu(user_update_rcu_disposal) to kfree_rcu() | Date | Thu, 31 Mar 2011 19:53:14 +0100 |
| |
David Howells <dhowells@redhat.com> wrote:
> > The rcu callback user_update_rcu_disposal() just calls a kfree(), > > so we use kfree_rcu() instead of the call_rcu(user_update_rcu_disposal). > > > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > > Nice idea, but how do you handle the container_of()?
Actually, you simply assume that the rcu_head is at the front of the struct, right? If you do that, you should alter the comment on struct user_key_payload in keys/user-type.h to note that this must be at the front.
David
| |