lkml.org 
[lkml]   [2011]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 05/12] mm: alloc_contig_range() added
From
Date
On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> + ret = 0;
> + while (!PageBuddy(pfn_to_page(start & (~0UL << ret))))
> + if (WARN_ON(++ret >= MAX_ORDER))
> + return -EINVAL;

Holy cow, that's dense. Is there really no more straightforward way to
do that?

In any case, please pull the ++ret bit out of the WARN_ON(). Some
people like to do:

#define WARN_ON(...) do{}while(0)

to save space on some systems.

-- Dave



\
 
 \ /
  Last update: 2011-03-31 18:05    [W:0.110 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site