| Date | Wed, 30 Mar 2011 22:26:28 -0700 | From | Yinghai Lu <> | Subject | Re: [PATCH] [225/275] x86: Cleanup highmap after brk is concluded |
| |
On 03/30/2011 02:07 PM, Andi Kleen wrote: > 2.6.35-longterm review patch. If anyone has any objections, please let me know. > > ------------------ > From: Yinghai Lu<yinghai@kernel.org> > > commit e5f15b45ddf3afa2bbbb10c7ea34fb32b6de0a0e upstream. > > Now cleanup_highmap actually is in two steps: one is early in head64.c > and only clears above _end; a second one is in init_memory_mapping() and > tries to clean from _brk_end to _end. > It should check if those boundaries are PMD_SIZE aligned but currently > does not. > Also init_memory_mapping() is called several times for numa or memory > hotplug, so we really should not handle initial kernel mappings there. > > This patch moves cleanup_highmap() down after _brk_end is settled so > we can do everything in one step. > Also we honor max_pfn_mapped in the implementation of cleanup_highmap. >
gentoo guys reported this one cause resume freeze.
https://bugs.gentoo.org/show_bug.cgi?id=361159
|