Messages in this thread | | | Subject | Re: [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present | From | Paul Bolle <> | Date | Thu, 31 Mar 2011 10:48:43 +0200 |
| |
(Something, somewhere, chocked on that "[.34+]@schatten.dmk.lab" address that was in the CC list, so I removed it. Invalid address? Invalid TLD?)
On Thu, 2011-03-31 at 10:01 +0200, Florian Mickler wrote: > diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c > index 68df09b..3940103 100644 > --- a/arch/x86/kernel/apic/io_apic.c > +++ b/arch/x86/kernel/apic/io_apic.c > @@ -3789,6 +3789,9 @@ int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity) > { > int ioapic, pin, idx; > > + if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC) > + return -1; > + > if (skip_ioapic_setup) > return -1; >
Seems to have the same goal as commit 678301ecadec24ff77ab310eebf8a32ccddb1850 ("x86, ioapic: Don't warn about non-existing IOAPICs if we have none"), which got merged in the v2.6.38 cycle (authored by me, signed off by Ingo Molnar). Maybe Eric's patch is more correct. I can't say as I was happy with the effect of my patch (ie, make an uninteresting error disappear) and didn't investigate any further. I have also no desire to dive into this matter again.
Paul
| |