lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [58/275] p54: fix sequence no. accounting off-by-one error
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Christian Lamparter <chunkeey@googlemail.com>

    commit 3b5c5827d1f80ad8ae844a8b1183f59ddb90fe25 upstream.

    P54_HDR_FLAG_DATA_OUT_SEQNR is meant to tell the
    firmware that "the frame's sequence number has
    already been set by the application."

    Whereas IEEE80211_TX_CTL_ASSIGN_SEQ is set for
    frames which lack a valid sequence number and
    either the driver or firmware has to assign one.

    Yup, it's the exact opposite!

    Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/net/wireless/p54/txrx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.35.y/drivers/net/wireless/p54/txrx.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/net/wireless/p54/txrx.c 2011-03-29 22:51:46.583531213 -0700
    +++ linux-2.6.35.y/drivers/net/wireless/p54/txrx.c 2011-03-29 23:02:59.358316589 -0700
    @@ -616,7 +616,7 @@
    else
    *burst_possible = false;

    - if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ)
    + if (!(info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ))
    *flags |= P54_HDR_FLAG_DATA_OUT_SEQNR;

    if (info->flags & IEEE80211_TX_CTL_PSPOLL_RESPONSE)

    \
     
     \ /
      Last update: 2011-03-30 23:57    [W:3.377 / U:0.644 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site