[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] [139/275] genirq: Disable the SHIRQ_DEBUG call in request_threaded_irq for now
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    From: Thomas Gleixner <>

    commit 6d83f94db95cfe65d2a6359cccdf61cf087c2598 upstream.

    With CONFIG_SHIRQ_DEBUG=y we call a newly installed interrupt handler
    in request_threaded_irq().

    The original implementation (commit a304e1b8) called the handler
    _BEFORE_ it was installed, but that caused problems with handlers
    calling disable_irq_nosync(). See commit 377bf1e4.

    It's braindead in the first place to call disable_irq_nosync in shared
    handlers, but ....

    Moving this call after we installed the handler looks innocent, but it
    is very subtle broken on SMP.

    Interrupt handlers rely on the fact, that the irq core prevents

    Now this debug call violates that promise because we run the handler
    w/o the IRQ_INPROGRESS protection - which we cannot apply here because
    that would result in a possibly forever masked interrupt line.

    A concurrent real hardware interrupt on a different CPU results in
    handler reentrancy and can lead to complete wreckage, which was
    unfortunately observed in reality and took a fricking long time to

    Leave the code here for now. We want this debug feature, but that's
    not easy to fix. We really should get rid of those
    disable_irq_nosync() abusers and remove that function completely.

    Signed-off-by: Thomas Gleixner <>
    Signed-off-by: Andi Kleen <>
    Cc: Anton Vorontsov <>
    Cc: David Woodhouse <>
    Cc: Arjan van de Ven <>
    Signed-off-by: Greg Kroah-Hartman <>

    kernel/irq/manage.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.35.y/kernel/irq/manage.c
    --- linux-2.6.35.y.orig/kernel/irq/manage.c 2011-03-29 22:51:11.695423912 -0700
    +++ linux-2.6.35.y/kernel/irq/manage.c 2011-03-29 23:03:01.175270097 -0700
    @@ -1093,7 +1093,7 @@
    if (retval)

    if (!retval && (irqflags & IRQF_SHARED)) {
    * It's a shared IRQ -- the driver ought to be prepared for it

     \ /
      Last update: 2011-03-30 23:41    [W:2.068 / U:1.876 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site