lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] UBI: do not select KALLSYMS_ALL
    Date
    From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

    All UBI needs is to make sure we stacktraces when UBI debugging
    is enabled. It is enough to select KALLSYMS for this, KALLSYMS_ALL
    is not necessary.

    And the current Kconfig line we have:

    select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL

    is just too complex to be sane and right. But this "if" part there
    is needed to prevent "unmet direct dependency" warnings, because
    KALLSYMS_ALL depends on KALLSYMS and DEBUG_KERNEL, so we cannot
    just select KALLSYMS_ALL.

    Anyway, this feels messy, and we do not seem to really need KALLSYMS_ALL,
    so select KALLSYMS instead.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    ---
    drivers/mtd/ubi/Kconfig | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
    index 6abeb4f..4dcc752 100644
    --- a/drivers/mtd/ubi/Kconfig
    +++ b/drivers/mtd/ubi/Kconfig
    @@ -56,7 +56,7 @@ config MTD_UBI_DEBUG
    bool "UBI debugging"
    depends on SYSFS
    select DEBUG_FS
    - select KALLSYMS_ALL if KALLSYMS && DEBUG_KERNEL
    + select KALLSYMS
    help
    This option enables UBI debugging.

    --
    1.7.2.3


    \
     
     \ /
      Last update: 2011-03-30 10:39    [W:0.028 / U:1.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site