lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [184/275] hwmon/f71882fg: Set platform drvdata to NULL later
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Hans de Goede <hdegoede@redhat.com>

    commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream.

    This avoids a possible race leading to trying to dereference NULL.

    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Acked-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/hwmon/f71882fg.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.35.y/drivers/hwmon/f71882fg.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/hwmon/f71882fg.c 2011-03-29 22:50:48.657013408 -0700
    +++ linux-2.6.35.y/drivers/hwmon/f71882fg.c 2011-03-29 23:03:02.087246763 -0700
    @@ -2100,7 +2100,6 @@
    int nr_fans = (data->type == f71882fg) ? 4 : 3;
    u8 start_reg = f71882fg_read8(data, F71882FG_REG_START);

    - platform_set_drvdata(pdev, NULL);
    if (data->hwmon_dev)
    hwmon_device_unregister(data->hwmon_dev);

    @@ -2167,6 +2166,7 @@
    }
    }

    + platform_set_drvdata(pdev, NULL);
    kfree(data);

    return 0;

    \
     
     \ /
      Last update: 2011-03-30 23:33    [W:0.021 / U:30.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site