lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [246/275] myri10ge: fix rmmod crash
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Stanislaw Gruszka <sgruszka@redhat.com>

    commit cda6587c21a887254c8ed4b58da8fcc4040ab557 upstream.

    Rmmod myri10ge crash at free_netdev() -> netif_napi_del(), because napi
    structures are already deallocated. To fix call netif_napi_del() before
    kfree() at myri10ge_free_slices().

    Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/net/myri10ge/myri10ge.c | 1 +
    1 file changed, 1 insertion(+)

    Index: linux-2.6.35.y/drivers/net/myri10ge/myri10ge.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/net/myri10ge/myri10ge.c 2011-03-29 22:50:13.908902524 -0700
    +++ linux-2.6.35.y/drivers/net/myri10ge/myri10ge.c 2011-03-29 23:03:03.419212681 -0700
    @@ -3600,6 +3600,7 @@
    dma_free_coherent(&pdev->dev, bytes,
    ss->fw_stats, ss->fw_stats_bus);
    ss->fw_stats = NULL;
    + netif_napi_del(&ss->napi);
    }
    }
    kfree(mgp->ss);

    \
     
     \ /
      Last update: 2011-03-30 23:19    [W:0.020 / U:29.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site