lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [117/275] [v3,media] av7110: check for negative array offset
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Dan Carpenter <error27@gmail.com>

    commit cb26a24ee9706473f31d34cc259f4dcf45cd0644 upstream.

    info->num comes from the user. It's type int. If the user passes
    in a negative value that would cause memory corruption.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    ---
    drivers/media/dvb/ttpci/av7110_ca.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    Index: linux-2.6.35.y/drivers/media/dvb/ttpci/av7110_ca.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/media/dvb/ttpci/av7110_ca.c 2011-03-29 22:51:21.638169502 -0700
    +++ linux-2.6.35.y/drivers/media/dvb/ttpci/av7110_ca.c 2011-03-29 23:03:00.655283403 -0700
    @@ -277,7 +277,7 @@
    {
    ca_slot_info_t *info=(ca_slot_info_t *)parg;

    - if (info->num > 1)
    + if (info->num < 0 || info->num > 1)
    return -EINVAL;
    av7110->ci_slot[info->num].num = info->num;
    av7110->ci_slot[info->num].type = FW_CI_LL_SUPPORT(av7110->arm_app) ?

    \
     
     \ /
      Last update: 2011-03-30 23:13    [W:2.752 / U:0.352 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site