lkml.org 
[lkml]   [2011]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Help with dma on PCI driver
    On Wed, 30 Mar 2011 13:11:40 -0300
    Luis Rossi <luisf.rossi@gmail.com> wrote:

    > should i stop the inti function on the device register,
    > and make all the rest inside probe? It makes a lot of sense as the
    > rest should be called just if the device is connected...

    Yes, you should. Also, please look at your cdev_add() call and bear in
    mind that your device can be accessed immediately after that call. You
    should not call cdev_add() until the device is completely initialized and
    ready to go.

    Some thought given to locking would also not be misplaced.

    Thanks,

    jon


    \
     
     \ /
      Last update: 2011-03-30 18:19    [W:0.019 / U:0.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site