Messages in this thread |  | | | Date | Thu, 3 Mar 2011 11:23:47 -0800 | | From | Randy Dunlap <> | | Subject | Re: [patch] Fix bug #13853: dereference pointer 'dev' before null check |
| |
On Wed, 02 Mar 2011 21:20:21 -0500 Jinqiu wrote:
> This patch fixes bug #13853 .This still exists in latest version. > 'dev' is dereferenced before testing for NULL. > > Signed-off-by: Jinqiu Yang<crindy646@gmail.com> > --- a/drivers/net/ariadne.c > +++ b/drivers/net/ariadne.c > @@ -420,7 +420,7 @@ static inline void ariadne_reset(struct > static irqreturn_t ariadne_interrupt(int irq, void *data) > {
It looks like thunderbird has split a long line into multiple lines for you. This is bad. See if Documentation/email-clients.txt can help you out any.
> struct net_device *dev = (struct net_device *) data; > - volatile struct Am79C960 *lance = (struct Am79C960*)dev->base_addr; > + volatile struct Am79C960 *lance; > struct ariadne_private *priv; > int csr0, boguscnt; > int handled = 0; > @@ -429,6 +429, 7 @@ static irqreturn_t ariadne_interrupt(int > printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n"); > return IRQ_NONE; > } > + lance = (struct Am79C960 *)dev->base_addr; > > lance->RAP = CSR0; /* PCnet-ISA Controller Status */ > > > > > --
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
|  |