lkml.org 
[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v9 1/1] PRUSS UIO driver support
    Date
    On Thursday 03 March 2011 19:07:57 Pratheesh Gangadhar wrote:
    > +struct uio_pruss_dev {
    > + struct uio_info *info;
    > + struct clk *pruss_clk;
    > + dma_addr_t sram_paddr;
    > + dma_addr_t ddr_paddr;
    > + void __iomem *prussio_vaddr;
    > + void *sram_vaddr;
    > + void *ddr_vaddr;
    > + unsigned int hostirq_start;
    > + unsigned int pintc_base;
    > +};
    > +
    > +struct pruss_priv {
    > + struct uio_pruss_dev *pupdev;
    > +};

    I cannot see the point of struct pruss_priv, I think it would be better to
    just merge the two data structures into one. Everything else looks
    good to me now.

    Arnd


    \
     
     \ /
      Last update: 2011-03-03 19:19    [W:0.018 / U:1.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site