Messages in this thread | | | Date | Thu, 3 Mar 2011 19:09:46 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH 8/8] Add VM counters for transparent hugepages |
| |
On Thu, Mar 03, 2011 at 10:18:27AM +0100, Johannes Weiner wrote: > On Wed, Mar 02, 2011 at 04:45:28PM -0800, Andi Kleen wrote: > > --- a/include/linux/vmstat.h > > +++ b/include/linux/vmstat.h > > @@ -58,6 +58,13 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > > UNEVICTABLE_PGCLEARED, /* on COW, page truncate */ > > UNEVICTABLE_PGSTRANDED, /* unable to isolate on unlock */ > > UNEVICTABLE_MLOCKFREED, > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + THP_FAULT_ALLOC, > > + THP_COLLAPSE_ALLOC, > > + THP_FAULT_FALLBACK, > > Wouldn't this better be named THP_FAULT_ALLOC_FAIL? After all, it > counts allocation failures, not what results from them.
It doesn't really fail anything for the user, so I thought fallback was better.
> > Secondly, the order does not match the strings, it will report the > THP_COLLAPSE_ALLOC item as "thp_fault_fallback" and vice versa.
Oops, I broke that while merging Andrea's change. Will resend.
> Can you make this "_failed" instead, to match the enum symbol? Andrea > wasn't sure which was better, "failure" or "failed". Right now, we > have two instances of "fail" and two instances of "failed" in > /proc/vmstat, it's probably best not to introduce a third one.
Okay.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |