lkml.org 
[lkml]   [2011]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH v8 1/1] PRUSS UIO driver support
    Hi,

    > -----Original Message-----
    > From: Arnd Bergmann [mailto:arnd@arndb.de]
    > Sent: Wednesday, March 02, 2011 6:52 PM
    > On Wednesday 02 March 2011, Pratheesh Gangadhar wrote:
    > > +
    > > +static struct clk *pruss_clk;
    > > +static struct uio_info *info;
    > > +static dma_addr_t sram_paddr, ddr_paddr;
    > > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
    > > +
    >
    > To my initial comment about these being single-instance
    > variables, you said you'd change that, which has not happened
    > yet.
    >
    I will do this in next version. Also realized that in next SoC,
    PRU INTC base offset is different, so plan to add a platform_data
    variable to make this portable.

    +#define PINTC_HIDISR 0x4038
    +#define PINTC_HIPIR 0x4900
    +#define PINTC_HIER 0x5500

    These hard coding also need to go to make it fully portable.
    +int intr_bit = (irq - IRQ_DA8XX_EVTOUT0 + 2);
    +p->irq = IRQ_DA8XX_EVTOUT0 + cnt;

    > Also, I now noticed that the types are wrong, you are
    > missing __iomem annotations for MMIO ranges. Please make
    > sure that the code builds fine with sparse and "make C=1",
    > which will tell you about these problems.
    >
    Thanks, this also helped to identify 2 unused lines in the code.

    + p->mem[1].internal_addr = sram_vaddr;
    + p->mem[2].internal_addr = ddr_vaddr;

    Pratheesh


    \
     
     \ /
      Last update: 2011-03-03 10:37    [W:0.129 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site