Messages in this thread | | | Date | Tue, 29 Mar 2011 10:40:55 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] uio: fix allocating minor id for uio device |
| |
> > - idev->minor = id & MAX_ID_MASK; > > + if (id < UIO_MAX_DEVICES) > > + idev->minor = id; > > + else {
As it needs respinning anyway: If the else-block has braces, it is recommended for the if-block, too
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature]
| |