Messages in this thread | | | Date | Tue, 29 Mar 2011 18:41:10 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH]mmap: add alignment for some variables |
| |
On Wed, 30 Mar 2011 09:36:40 +0800 Shaohua Li <shaohua.li@intel.com> wrote:
> > how is it that this improves things? > Hmm, it actually is: > struct percpu_counter { > spinlock_t lock; > s64 count; > #ifdef CONFIG_HOTPLUG_CPU > struct list_head list; /* All percpu_counters are on a list */ > #endif > s32 __percpu *counters; > } __attribute__((__aligned__(1 << (INTERNODE_CACHE_SHIFT)))) > so lock and count are in one cache line.
____cacheline_aligned_in_smp would achieve that?
| |