Messages in this thread | | | Date | Tue, 29 Mar 2011 19:32:21 +0200 | From | Daniel Kiper <> | Subject | Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro |
| |
On Mon, Mar 28, 2011 at 03:46:27PM -0700, David Rientjes wrote: > On Mon, 28 Mar 2011, Daniel Kiper wrote: > > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > > index 02ecb01..d342820 100644 > > --- a/include/linux/mmzone.h > > +++ b/include/linux/mmzone.h > > @@ -931,6 +931,9 @@ static inline unsigned long early_pfn_to_nid(unsigned long pfn) > > #define pfn_to_section_nr(pfn) ((pfn) >> PFN_SECTION_SHIFT) > > #define section_nr_to_pfn(sec) ((sec) << PFN_SECTION_SHIFT) > > > > +#define SECTION_ALIGN_UP(pfn) (((pfn) + PAGES_PER_SECTION - 1) & PAGE_SECTION_MASK) > > +#define SECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SECTION_MASK) > > + > > #ifdef CONFIG_SPARSEMEM > > > > /* > > These are only valid for CONFIG_SPARSEMEM, so they need to be defined > conditionally.
OK, however, I think that pfn_to_section_nr()/section_nr_to_pfn() should be defined conditionally, too.
Daniel
| |