Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig | Date | Wed, 30 Mar 2011 01:39:46 +0900 |
| |
Randy Dunlap <randy.dunlap@oracle.com> writes:
>> config PCI_LABEL >> bool >> select NLS >> depends on (DMI || ACPI) > > What sets/enables it then? > or did you mean: > def_bool y > and in that case, should it be a user-visible & user-changeable kconfig option?
Whoops, last line was missed by copy&paste. It meant
config PCI_LABEL bool select NLS depends on (DMI || ACPI) default y
And no, it shouldn't be user-changeable (it would be better to invisible in .config. At make *config, already invisible.). Because PCI_LABEL is not user config and not used in Makefile.
And yeah, if you like def_bool
config PCI_LABEL def_bool y if (DMI || ACPI) select NLS
I guess it would work (it should be just syntax sugar and equivalent).
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |