lkml.org 
[lkml]   [2011]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
Date
Randy Dunlap <randy.dunlap@oracle.com> writes:

>> config PCI_LABEL
>> bool
>> select NLS
>> depends on (DMI || ACPI)
>
> What sets/enables it then?
> or did you mean:
> def_bool y
> and in that case, should it be a user-visible & user-changeable kconfig option?

Whoops, last line was missed by copy&paste. It meant

config PCI_LABEL
bool
select NLS
depends on (DMI || ACPI)
default y

And no, it shouldn't be user-changeable (it would be better to
invisible in .config. At make *config, already invisible.). Because
PCI_LABEL is not user config and not used in Makefile.

And yeah, if you like def_bool

config PCI_LABEL
def_bool y if (DMI || ACPI)
select NLS

I guess it would work (it should be just syntax sugar and equivalent).

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


\
 
 \ /
  Last update: 2011-03-29 18:43    [W:1.240 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site