Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH] block: eliminate ELEVATOR_INSERT_REQUEUE (was: Re: elevator private data for REQ_FLUSH) | Date | Tue, 29 Mar 2011 10:13:05 -0400 |
| |
Mike Snitzer <snitzer@redhat.com> writes:
> OK, I came up with the following patch. > > Jens, this is just a natural cleanup given the code that resulted from > the flush-merge and onstack plugging changes coming together. > > > From: Mike Snitzer <snitzer@redhat.com> > Subject: block: eliminate ELEVATOR_INSERT_REQUEUE > > elv_insert() no longer has a need to differentiate between > ELEVATOR_INSERT_REQUEUE and ELEVATOR_INSERT_FRONT. The onstack plugging > changes eliminated the need to avoid unplugging the queue (via > ELEVATOR_INSERT_REQUEUE). > > Also, in blk_insert_flush(), use elv_insert() with ELEVATOR_INSERT_FRONT > rather than open-coding the equivalent.
What you change by doing the call to elv_insert is that now the request will have REQ_SOFTBARRIER set. I don't think that affects anything, though (I checked). The rest looks pretty straight-forward.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
| |