Messages in this thread | | | Date | Tue, 29 Mar 2011 06:12:19 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/6] TTY: unify tty_init_dev fail path handling |
| |
On Tue, Mar 29, 2011 at 02:17:42PM +0200, Jiri Slaby wrote: > On 03/23/2011 09:53 PM, Julian Anastasov wrote: > > > > Hello, > > > > On Wed, 23 Mar 2011, Jiri Slaby wrote: > > > >> Change it so that we call the deinit functions at one place at the end > >> of the function (by gotos). And while at it use some sane label names. > >> > >> This is a preparation for the deinitialization of tty in the next > >> patch. > >> > >> Signed-off-by: Jiri Slaby <jslaby@suse.cz> > >> Cc: Greg Kroah-Hartman <gregkh@suse.de> > >> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> > >> Cc: Julian Anastasov <ja@ssi.bg> > >> --- > >> > >> This is not tested yet, I'm building a kernel to test it a bit, but it > >> will take some time. If you could too to check if your problem > >> dissapears, it would be great. > > > > Thanks! Patches 1-5 work for me, I backported them > > to 2.6.33.8 for the test. > > Thanks for testing. I see no regressions either. > > Greg, will you take it?
Yes I will queue it up in a week or so, thanks.
greg k-h
| |