lkml.org 
[lkml]   [2011]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] block drivers for 2.6.39-rc
Hi Linus, Ingo,

On Sun, 27 Mar 2011 21:37:50 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Sun, Mar 27, 2011 at 9:23 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > This driver does not build at all:
> >
> >  drivers/block/drbd/drbd_bitmap.c:1187:5: error: implicit declaration of function ‘generic_find_next_zero_le_bit’ [-Werror=implicit-function-declaration]
> >  drivers/block/drbd/drbd_bitmap.c:1190:5: error: implicit declaration of function ‘generic_find_next_le_bit’ [-Werror=implicit-function-declaration]
> >  drivers/block/drbd/drbd_bitmap.c:1290:4: error: implicit declaration of function ‘generic___test_and_set_le_bit’ [-Werror=implicit-function-declaration]
> >  drivers/block/drbd/drbd_bitmap.c:1292:4: error: implicit declaration of function ‘generic___test_and_clear_le_bit’ [-Werror=implicit-function-declaration]
> >  drivers/block/drbd/drbd_bitmap.c:1441:3: error: implicit declaration of function ‘generic_test_le_bit’ [-Werror=implicit-function-declaration]
> >
> > Has this been build-tested? These APIs do not exist upstream.
>
> Actually, I think that's just a merge error - those horrible nasty
> crazy names did use to exist.
>
> Does this fix it? (Untested!)

You also need to remove the include of asm-generic/bitops/le.h from that
file now (the easiest way is to revert commit f0ff1357ce39 ("drbd: need
include for bitops functions declarations").

Jens was informed about these problems when they appeared in linux-next.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-03-28 07:11    [W:0.065 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site