Messages in this thread | | | Date | Sun, 27 Mar 2011 19:02:30 +0400 | From | Sergei Shtylyov <> | Subject | Re: [patch 17/23] arm: at91: Cleanup irq chip |
| |
Hello.
On 26-03-2011 0:03, Thomas Gleixner wrote:
>> Avoid the whole lazy disable dance in the demux handler by providing a >> irq_disable() callback.
>> Use the proper accessor functions and tidy up gpio_irq_handler()
>> Signed-off-by: Thomas Gleixner<tglx@linutronix.de> [...]
>> Index: linux-2.6-tip/arch/arm/mach-at91/gpio.c >> =================================================================== >> --- linux-2.6-tip.orig/arch/arm/mach-at91/gpio.c >> +++ linux-2.6-tip/arch/arm/mach-at91/gpio.c [...] >> @@ -384,16 +385,14 @@ static struct irq_chip gpio_irqchip = { >> static void gpio_irq_handler(unsigned irq, struct irq_desc *desc) >> { >> unsigned pin; >> - struct irq_desc *gpio; >> - struct at91_gpio_chip *at91_gpio; >> - void __iomem *pio; >> + struct irq_data *idata = irq_desc_get_irq_data(desc); >> + struct irq_chip *chip = irq_data_get_chip(data); >> + struct at91_gpio_chip *at91_gpio = irq_data_get_chip_data(data);
> Sorry, needs to be
> + struct at91_gpio_chip *at91_gpio = irq_data_get_irq_chip_data(data);
> Will fix and resend.
You also don't have 'data' defined anywhere, maybe you meant 'ídata'?
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |