lkml.org 
[lkml]   [2011]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH,RFC] perf: panic due to inclied cpu context task_ctx value
On 03/26, Peter Zijlstra wrote:
>
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index c75925c..e9e4e35 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -1073,6 +1073,8 @@ event_sched_out(struct perf_event *event,
> if (!is_software_event(event))
> cpuctx->active_oncpu--;
> ctx->nr_active--;
> + if (!ctx->nr_active && cpuctx->task_ctx == ctx)
> + cpuctx->task_ctx = NULL;

If we clear cpuctx->task_ctx, we should also clear ctx->is_active.

Otherwise I can't see any problem, but I do not understand this code
enough.

Oleg.



\
 
 \ /
  Last update: 2011-03-26 18:21    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site