lkml.org 
[lkml]   [2011]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[29/35] USB: cdc-acm: fix potential null-pointer dereference
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Johan Hovold <jhovold@gmail.com>

    commit 15e5bee33ffc11d0e5c6f819a65e7881c5c407be upstream.

    Must check return value of tty_port_tty_get.

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/class/cdc-acm.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/usb/class/cdc-acm.c
    +++ b/drivers/usb/class/cdc-acm.c
    @@ -534,6 +534,8 @@ static void acm_softint(struct work_stru
    if (!ACM_READY(acm))
    return;
    tty = tty_port_tty_get(&acm->port);
    + if (!tty)
    + return;
    tty_wakeup(tty);
    tty_kref_put(tty);
    }



    \
     
     \ /
      Last update: 2011-03-26 01:11    [W:0.019 / U:0.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site