lkml.org 
[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateThu, 24 Mar 2011 21:44:34 +0100 (CET)
FromJesper Juhl <>
Subject[PATCH] TerraTec DMX 6Fire USB: Don't leak firmware when usb6fire_fw_ihex_init() fails.
We need to release_firmware() what we request_firmware()'ed when 
usb6fire_fw_ihex_init() fails or we'll leak memory.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
firmware.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c
index 9081a54..2761392 100644
--- a/sound/usb/6fire/firmware.c
+++ b/sound/usb/6fire/firmware.c
@@ -254,6 +254,7 @@ static int usb6fire_fw_ezusb_upload(
ret = usb6fire_fw_ihex_init(fw, rec);
if (ret < 0) {
kfree(rec);
+ release_firmware(fw);
snd_printk(KERN_ERR PREFIX "error validating ezusb "
"firmware %s.\n", fwname);
return ret;


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-03-24 21:59    [from the cache]
©2003-2010