Messages in this thread | | | Date | Thu, 24 Mar 2011 21:27:09 +0200 | Subject | Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 | From | Pekka Enberg <> |
| |
On Thu, Mar 24, 2011 at 9:22 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Thomas Gleixner <tglx@linutronix.de> wrote: > >> On Thu, 24 Mar 2011, Ingo Molnar wrote: >> > RIP: 0010:[<ffffffff810570a9>] [<ffffffff810570a9>] get_next_timer_interrupt+0x119/0x260 >> >> That's a typical timer crash, but you were unable to debug it with >> debugobjects because commit d3f661d6 broke those. >> >> Christoph, debugobjects do not need to run with interupts >> disabled. And just because they were in that section to keep all the >> debug stuff together does not make an excuse for not looking at the >> code and just slopping it into some totally unrelated ifdef along with >> a completely bogus comment. >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> >> --- >> mm/slub.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Index: linux-2.6/mm/slub.c >> =================================================================== >> --- linux-2.6.orig/mm/slub.c >> +++ linux-2.6/mm/slub.c >> @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct >> local_irq_save(flags); >> kmemcheck_slab_free(s, x, s->objsize); >> debug_check_no_locks_freed(x, s->objsize); >> - if (!(s->flags & SLAB_DEBUG_OBJECTS)) >> - debug_check_no_obj_freed(x, s->objsize); >> local_irq_restore(flags); >> } >> #endif >> + if (!(s->flags & SLAB_DEBUG_OBJECTS)) >> + debug_check_no_obj_freed(x, s->objsize); > > Thanks, this did the trick! > > Tested-by: Ingo Molnar <mingo@elte.hu> > > With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c > timer bug.
Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |