lkml.org 
[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] perf, x86: P4 PMU - Add missing read of a counter before test

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> On 03/24/2011 11:48 AM, Ingo Molnar wrote:
> >
> > * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> >
> >> Don, I've added yours SOB, ok? (The patch is attached to avoid
> >> space/tabs problem
> >> due to web-mail client)
> >
> > The patch lacks a proper description about the motivation and effects of the
> > patch.
> >
> > Thanks,
> >
> > Ingo
>
> Ingo, does this one looks better?
>
> ---
> From: Don Zickus <dzickus@redhat.com>
> Subject: [PATCH -tip] perf, x86: P4 PMU - Add missing read of MSR register to catch unflagged overflows
>
> The read of a proper MSR register was missed so instead of a counter the
> configration register is tested (it has ARCH_P4_UNFLAGGED_BIT always cleared)
> and unflagged overflows never have been catched. Fix it by reading a proper
> MSR register.

So what effect does this have on the regular perf user? Please try to describe
the real-life effect of the bug/problem fixed here.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-03-24 17:35    [W:0.064 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site