lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely
    Date
    > > Reported-by: Andrey Vagin <avagin@openvz.org>
    > > Cc: Nick Piggin <npiggin@kernel.dk>
    > > Cc: Minchan Kim <minchan.kim@gmail.com>
    > > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > > Cc: Rik van Riel <riel@redhat.com>
    > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
    >
    > IIUC, I saw the pehnomenon which you pointed out, as
    > - all zone->all_unreclaimable = yes
    > - zone_reclaimable() returns true
    > - no pgscan proceeds.
    >
    > on a swapless system. So, I'd like to vote for this patch.
    >
    > But hmm...what happens all of pages are isolated or locked and now under freeing ?
    > I think we should have alternative safe-guard logic for avoiding to call
    > oom-killer. Hmm.

    Yes, this patch has small risk. but 1) this logic didn't work about two
    years (see changelog) 2) memcg haven't use this logic and I haven't get
    any bug report from memcg developers. therefore I decided to take most
    simple way.

    Of cource, I'll make another protection if I'll get any regression report.





    \
     
     \ /
      Last update: 2011-03-23 08:57    [W:0.025 / U:34.232 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site