lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] cfq-iosched: Don't clear queue stats when preempt.
On 2011-03-22 23:35, Justin TerAvest wrote:
> For v2, I added back lines to cfq_preempt_queue() that were removed
> during updates for accounting unaccounted_time. Thanks for pointing out
> that I'd missed these, Vivek.
>
> Previous commit "cfq-iosched: Don't set active queue in preempt" wrongly
> cleared stats for preempting queues when it shouldn't have, because when
> we choose a queue to preempt, it still isn't necessarily scheduled next.
>
> Thanks to Vivek Goyal for figuring this out and understanding how the
> preemption code works.

Thanks to both of you, applied.

--
Jens Axboe



\
 
 \ /
  Last update: 2011-03-23 08:33    [W:2.452 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site