lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/5] x86,mm: make pagefault killable
    On Wed, Mar 23, 2011 at 1:09 AM, KOSAKI Motohiro
    <kosaki.motohiro@jp.fujitsu.com> wrote:
    >
    > When __lock_page_or_retry() return 0, It call up_read(mmap_sem) in this
    > function.

    Indeed.

    > I agree this is strange (or ugly). but I don't want change this spec in
    > this time.

    I agree that it is strange, and I don't like functions that touch
    locks that they didn't take themselves, but since the original point
    of the whole thing was to wait for the page without holding the
    mmap_sem lock, that function has to do the up_read() early.

    Linus


    \
     
     \ /
      Last update: 2011-03-23 15:37    [W:0.020 / U:1.168 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site