lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH V4 1/5] cpuidle: Remove pm_idle pointer for x86
    Hi Stephen,

    On 03/23/2011 06:30 AM, Stephen Rothwell wrote:
    > Hi,
    >
    > Just some simple comments.
    >
    > Does having this patch first in the series break APM idle?

    Thanks for reviewing.
    Yes, I think removal of "pm_idle = default_idle" statement in
    APM may have to be moved here.
    >
    > On Tue, 22 Mar 2011 18:02:27 +0530 Trinabh Gupta<trinabh@linux.vnet.ibm.com> wrote:
    >>
    >> diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
    >> index 8d12878..17b7101 100644
    >> --- a/arch/x86/kernel/process_32.c
    >> +++ b/arch/x86/kernel/process_32.c
    >> @@ -74,6 +74,8 @@ static inline void play_dead(void)
    >> }
    >> #endif
    >>
    >> +extern void cpuidle_idle_call(void);
    >
    > Put this declaration in a header file and include that header file here
    > and in the file that defines that function.
    >

    Ok, thanks

    -Trinabh


    \
     
     \ /
      Last update: 2011-03-23 11:13    [W:0.022 / U:120.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site