Messages in this thread |  | | | Date | Tue, 22 Mar 2011 20:16:38 -0700 | | From | Stephen Boyd <> | | Subject | Re: [PATCH] ARM: Use asm-generic/sizes.h |
| |
On 03/22/2011 06:29 PM, Guan Xuetao wrote: >> -----Original Message----- >> From: Stephen Boyd [mailto:sboyd@codeaurora.org] >> Sent: Wednesday, March 23, 2011 2:40 AM >> To: Guan Xuetao >> Cc: 'Arnd Bergmann'; linux-arm-kernel@lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h >> Ah, I didn't notice this part. SZ_48M is actually used by ARM code so >> that would need to be added to the generic header should we go with this >> patch. > IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions. > And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers. > >
I'm hoping that kbuild gets asm-generic support sometime soon so files with only a "#include <asm-generic/*>" are generated instead of living in the tree. In that case I'd rather have the non power of 2 constants added to the generic sizes.h and be done with it. There isn't any strong technical reason to deny power of 2 constants from the generic header, right? Note: SH could also move to this if SZ_26M is put in the generic header.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
|  |