lkml.org 
[lkml]   [2011]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[patch 00/15] CFS Bandwidth Control V5
    Hi all,

    Please find attached the latest version of bandwidth control for the normal
    scheduling class. This revision has undergone fairly extensive changes since
    the previous version based largely on the observation that many of the edge
    conditions requiring special casing around update_curr() were a result of
    introducing side-effects into that operation. By introducing an interstitial
    state, where we recognize that the runqueue is over bandwidth, but not marking
    it throttled until we can actually remove it from the CPU we avoid the
    previous possible interactions with throttled entities which eliminates some
    head-scratching corner cases.

    In particular I'd like to thank Peter Zijlstra who provided extensive comments
    and review for the last series.

    Changes since v4:

    New features:
    - Bandwidth control now properly works with hotplug, throttled tasks are
    returned to rq on cpu-offline so that they can be migrated.
    - It is now validated that hierarchies are consistent with their resource
    reservations. That is, the sum of a sub-hierarchy's bandwidth requirements
    will not exceed the bandwidth provisioned to the parent. (This enforcement
    is optional and controlled by a sysctl.)
    - It is now tracked whether quota is 'current' or not, this allows for the
    expiration of slack quota from prioir scheduling periors as well as the return
    of quota by idling cpus.

    Major:
    - The atomicity of update_curr() is restored, it will now only perform the
    accounting required for bandwidth control. The act of checking whether
    quota has been exceeded is made explicit. This avoids the previous corner
    cases required in enqueue/dequeue-entity.
    - The act of throttling is now deferred until we reach put_task(). This means
    that the transition to throttled is atomic and the special case interactions
    with a running-but-throttled-entity (in the case where we couldn't previously
    immediately handle a resched) are no longer needed.
    - The correction for shares accounting during a throttled period has been
    extended to work for the children of a throttled run-queue.
    - Throttled cfs_rqs are now explicitly tracked using a list, this avoids the
    need to revisit every cfs_rq on period expiration on large systems.


    Minor:
    - Hierarchal task accounting is no longer a separate hierachy evaluation.
    - (Buglet) nr_running accounting added to sched::stoptask
    - (Buglet) Will no longer load balance the child hierarchies of a throttled
    entity.
    - (Fixlet) don't process dequeued entities twice in dequeue_task_fair()
    - walk_tg_tree refactored to allow for partial sub-tree evaluations.
    - Dropped some #ifdefs
    - Fixed some compile warnings with various CONFIG permutations
    - Local bandwidth is now consumed "negatively"
    - Quota slices now 5ms

    Probably some others that I missed, there was a lot of refactoring and cleanup.

    Interface:
    ----------
    Three new cgroupfs files are exported by the cpu subsystem:
    cpu.cfs_period_us : period over which bandwidth is to be regulated
    cpu.cfs_quota_us : bandwidth available for consumption per period
    cpu.stat : statistics (such as number of throttled periods and
    total throttled time)
    One important interface change that this introduces (versus the rate limits
    proposal) is that the defined bandwidth becomes an absolute quantifier.

    Previous postings:
    -----------------
    v4:
    https://lkml.org/lkml/2011/2/23/44
    v3:
    https://lkml.org/lkml/2010/10/12/44
    v2:
    http://lkml.org/lkml/2010/4/28/88
    Original posting:
    http://lkml.org/lkml/2010/2/12/393

    Prior approaches:
    http://lkml.org/lkml/2010/1/5/44 ["CFS Hard limits v5"]

    Thanks,

    - Paul





    \
     
     \ /
      Last update: 2011-03-23 04:13    [W:2.235 / U:0.600 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site