Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH] USB: cdc-acm: Prevent data loss when filling tty buffer. | Date | Tue, 22 Mar 2011 09:07:42 +0100 |
| |
Am Montag, 21. März 2011, 17:56:12 schrieb Alan Cox: > On Mon, 21 Mar 2011 15:52:25 +0000 > Toby Gray <toby.gray@realvnc.com> wrote: > > > When sending large quantities of data through a CDC ACM channel it is possible > > for data to be lost when attempting to copy the data to the tty buffer. This > > occurs due to the return value from tty_insert_flip_string not being checked. > > For a tty that is normally the right thing to do - no flow control was > asserted and the internal 64K of buffering was overrun so discard.
But should we really randomly discard a part of a buffer? If this happens the better alternative approach would be to nuke all buffers we currently have.
Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |