Messages in this thread | | | Date | Tue, 22 Mar 2011 09:26:03 -0700 | From | Greg KH <> | Subject | Re: [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct) |
| |
On Tue, Mar 22, 2011 at 12:51:31PM +0200, Oren Weil wrote: > +/* > + * Intel MEI client information struct > + */ > +struct mei_client { > + u32 max_msg_length; > + u8 protocol_version; > + u8 reserved[3]; > +} __packed;
As this is passing the kernel/user boundry, you need to use the proper data types for it.
So use __u32 and __u8 here please.
> +/* > + * IOCTL Connect Client Data structure > + */ > +struct mei_connect_client_data { > + union { > + uuid_le in_client_uuid; > + struct mei_client out_client_propeties; > + } d;
Why not an anonymous union?
thanks,
greg k-h
| |