lkml.org 
[lkml]   [2011]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct)
On Tue, Mar 22, 2011 at 12:51:31PM +0200, Oren Weil wrote:
> +/*
> + * Intel MEI client information struct
> + */
> +struct mei_client {
> + u32 max_msg_length;
> + u8 protocol_version;
> + u8 reserved[3];
> +} __packed;

As this is passing the kernel/user boundry, you need to use the proper
data types for it.

So use __u32 and __u8 here please.

> +/*
> + * IOCTL Connect Client Data structure
> + */
> +struct mei_connect_client_data {
> + union {
> + uuid_le in_client_uuid;
> + struct mei_client out_client_propeties;
> + } d;

Why not an anonymous union?

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-03-22 17:29    [W:0.202 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site