Messages in this thread | | | Date | Mon, 21 Mar 2011 10:20:28 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 04/10] block: initial patch for on-stack per-task plugging |
| |
On 2011-03-21 07:52, Shaohua Li wrote: >> Gave it a quick test spin, as suspected it had a few issues. This one >> seems to work. Can you toss it through that workload and see if it fares >> better? > yes, this fully restores the regression I saw. But I have accounting > issue:
Great!
> 1. The merged request is already accounted when it's added into plug > list
Good catch. I've updated the patch and merged it now, integrating this accounting fix.
> 2. drive_stat_acct() is called without any protection in > __make_request(). So there is race for in_flight accounting. The race > exists after stack plug is added, so not because of this issue. > Below is the extra patch I need to do the test.
Looks fine. Can I add your signed-off-by to this patch? I'll merge it as a separate fix.
-- Jens Axboe
| |