Messages in this thread Patch in this message | | | Date | Mon, 21 Mar 2011 16:06:00 -0700 | From | Greg KH <> | Subject | [01/87] hwmon/f71882fg: Set platform drvdata to NULL later |
| |
2.6.37-stable review patch. If anyone has any objections, please let us know.
------------------
From: Hans de Goede <hdegoede@redhat.com>
commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream.
This avoids a possible race leading to trying to dereference NULL.
Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/hwmon/f71882fg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hwmon/f71882fg.c +++ b/drivers/hwmon/f71882fg.c @@ -2110,7 +2110,6 @@ static int f71882fg_remove(struct platfo int nr_fans = (data->type == f71882fg) ? 4 : 3; u8 start_reg = f71882fg_read8(data, F71882FG_REG_START); - platform_set_drvdata(pdev, NULL); if (data->hwmon_dev) hwmon_device_unregister(data->hwmon_dev); @@ -2177,6 +2176,7 @@ static int f71882fg_remove(struct platfo } } + platform_set_drvdata(pdev, NULL); kfree(data); return 0;
| |