lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[26/78] USB: serial/kobil_sct, fix potential tty NULL dereference
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jiri Slaby <jslaby@suse.cz>

    commit 6960f40a954619857e7095a6179eef896f297077 upstream.

    Make sure that we check the return value of tty_port_tty_get.
    Sometimes it may return NULL and we later dereference that.

    The only place here is in kobil_read_int_callback, so fix it.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Alan Cox <alan@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/serial/kobil_sct.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/kobil_sct.c
    +++ b/drivers/usb/serial/kobil_sct.c
    @@ -372,7 +372,7 @@ static void kobil_read_int_callback(stru
    }

    tty = tty_port_tty_get(&port->port);
    - if (urb->actual_length) {
    + if (tty && urb->actual_length) {

    /* BEGIN DEBUG */
    /*



    \
     
     \ /
      Last update: 2011-03-22 00:33    [W:4.574 / U:0.468 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site