lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] job control: Don't send duplicate job control stop notification while ptraced
On 03/08, Tejun Heo wrote:
>
> static bool task_participate_group_stop(struct task_struct *task)
> {
> @@ -284,7 +288,11 @@ static bool task_participate_group_stop(struct task_struct *task)
> if (!WARN_ON_ONCE(sig->group_stop_count == 0))
> sig->group_stop_count--;
>
> - if (!sig->group_stop_count) {
> + /*
> + * Tell the caller to notify completion iff we are entering into a
> + * fresh group stop. Read comment in do_signal_stop() for details.
> + */
> + if (!sig->group_stop_count && !(sig->flags & SIGNAL_STOP_STOPPED)) {
> sig->flags = SIGNAL_STOP_STOPPED;
> return true;

Ah, indeed. And this fixes the problems with the extra notification I
mentioned when I was looking at 1/8.

Oleg.



\
 
 \ /
  Last update: 2011-03-21 19:01    [from the cache]
©2003-2011 Jasper Spaans