Messages in this thread | | | Date | Mon, 21 Mar 2011 16:41:56 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 07/20] video: msm: Allow users to request a larger x and y virtual fb |
| |
On Mon, Mar 21, 2011 at 10:10:09AM +0530, Janorkar, Mayuresh wrote: > > + fix->line_length = var->xres * var->bits_per_pixel / 8; > Why to divide by 8? Atleast use >>3, bitwise operations that would take > less cpu cycles) > As I stated earlier define a new macro for var also.
Modern compilers know about such things. >> 3 vs / 8 (probably) makes no difference to the generated code with the toolchains we use.
| |