Messages in this thread |  | | | Date | Mon, 21 Mar 2011 15:58:37 +0000 | | From | Mark Brown <> | | Subject | Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1 |
| |
On Mon, Mar 21, 2011 at 04:37:19PM +0100, Ingo Molnar wrote:
> has been pushed upstream - although the build breakage was reported against > linux-next two weeks ago, with fix provided, in this lkml thread: > > [PATCH -next] soc: sgtl5000 uses regulator interfaces
Zheng, you said you'd provide a better patch for this but I've heard nothing since? It's a trivial change you need to make...
> Please do not push known-broken code upstream.
That seems like an overreaction, it'll only show up in fairly unrealstic randconfigs and can be trivially avoided by anyone who actually needs the driver - core things like all*config won't be affected, and right now it'll only come up at all if you enable SND_SOC_ALL_CODECS which is purely about build coverage.
> Randy's fix below resolved the bug for me.
As indicated that's not a good fix since the affected code is all runtime conditional already. It'd be more likely to impede than help the sort of build coverage tests where one would encounter it.
|  |