[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
    On Mon, Mar 21, 2011 at 04:37:19PM +0100, Ingo Molnar wrote:

    > has been pushed upstream - although the build breakage was reported against
    > linux-next two weeks ago, with fix provided, in this lkml thread:
    > [PATCH -next] soc: sgtl5000 uses regulator interfaces

    Zheng, you said you'd provide a better patch for this but I've heard
    nothing since? It's a trivial change you need to make...

    > Please do not push known-broken code upstream.

    That seems like an overreaction, it'll only show up in fairly unrealstic
    randconfigs and can be trivially avoided by anyone who actually needs
    the driver - core things like all*config won't be affected, and right
    now it'll only come up at all if you enable SND_SOC_ALL_CODECS which is
    purely about build coverage.

    > Randy's fix below resolved the bug for me.

    As indicated that's not a good fix since the affected code is all
    runtime conditional already. It'd be more likely to impede than help
    the sort of build coverage tests where one would encounter it.

     \ /
      Last update: 2011-03-21 17:01    [W:0.025 / U:40.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site