lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/5] make sdhci device drivers self registered
    On Mon, Mar 21, 2011 at 01:39:45PM +0100, Arnd Bergmann wrote:
    [...]
    >
    > Hi Shawn,
    >
    Hi Arnd,

    > The changes you make look very nice, great work there!
    >
    > I think the split of the series into five patches is not ideal
    > because you have more interdependencies than necessary, and it's
    > not clear that the series can be safely bisected, especially
    > with the way you do all the Kconfig/Makefile updates at the
    > end.
    >
    > A nicer way to partition the series would be
    >
    > 1. Add sdhci_pltfm_init helper
    > 2-5. Convert each of the users, including the respective
    > Kconfig/Makefile changes
    > 6. remove obsolete code from sdhci-pltfm.c
    >
    > As I said, that's just a detail and the end result is the same.
    > If you don't get any other feedback and Chris is happy with the
    > changes, I wouldn't expect you to reshuffle all the patches just
    > for this.
    >
    > Acked-by: Arnd Bergmann <arnd@arndb.de>
    >
    Actually, I knew there should be better partition of the patch set,
    and it just did not come into my mind :) You suggestion does look
    better. I would take it in the next spin.

    Thanks for the suggestion.

    --
    Regards,
    Shawn



    \
     
     \ /
      Last update: 2011-03-21 13:55    [W:4.378 / U:1.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site