lkml.org 
[lkml]   [2011]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: aligning with spaces [was: Re: format fixes]
On Sun, 20 Mar 2011 14:39:13 +0100 Arne Jansen wrote:

> On 20.03.2011 11:45, Jeffrin Jose wrote:
> > I have created a patch with fixes and format
> > error by replacing spaces with tabs.
>
> The CodingStyle guide seems to me a big vague on this topic, but
> checkpatch.pl has a clear idea of what is right and wrong. But
> the formerly present indentation seems to me totally valid.

AFAICT, the patch replaces 8 spaces with 1 tab. That's a good change
IMO, except that the patch does not apply to linux-next 2011-0318.
I can't tell if the patch was made against an earlier tree or a later one.
In either case, it looks like this particular printk has probably already
been fixed by some other patch.

> Use tab to indent to the current indentation level, then continue
> with spaces for the alignment of broken-up lines. This has a
> few advantages. One of them is that the code still looks neat with
> a different tab size (of course, no one ever does that). Another is,
> that editing is easier if you change the name of the function and
> with it the needed alignment for the following lines.
> If we really require using tabs as much as possible for aligning, we
> should also _only_ use tabs for it and require e.g. 2 tabs for
> broken-up lines.
> In fact, the example in CodingStyle uses only tabs and does not try
> to align the double quotes of the broken-up string with each other.

We accept patches either way, but it mostly depends on (a) the
current/surrounding code and (b) the maintainer who is merging the patches.

CodingStyle may be vague on all of this. It's easy to be ambiguous or
vague in language, even when you try not to be.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

\
 
 \ /
  Last update: 2011-03-20 18:37    [W:0.443 / U:0.960 seconds]
©2003-2014 Jasper Spaans. Advertise on this site