lkml.org 
[lkml]   [2011]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2] fs/9p: Use updated offset for writing
Date
On Wed, 16 Mar 2011 21:40:49 +0530, "M. Mohan Kumar" <mohan@in.ibm.com> wrote:
> Use the updated offset given by generic_write_checks. Without this fix,
> even if a file is opened in O_APPEND mode, data will be written at current
> file position instead of end of file.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Eric,

I guess this should go in this merge window ?

> ---
> fs/9p/vfs_file.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 6997eb6..ffed558 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -508,9 +508,12 @@ v9fs_file_write(struct file *filp, const char __user * data,
> if (!count)
> goto out;
>
> - return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> + retval = v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> filp->private_data,
> - data, count, offset, 1);
> + data, count, &origin, 1);
> + /* update offset on successful write */
> + if (retval > 0)
> + *offset = origin;
> out:
> return retval;
> }


\
 
 \ /
  Last update: 2011-03-20 14:59    [W:0.050 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site