lkml.org 
[lkml]   [2011]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] kdump: Allow shrinking of kdump region to be overridden
    Date
    On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote:

    > On Tue, Mar 15, 2011 at 03:52:38PM +0800, Américo Wang wrote:
    >> On Tue, Mar 15, 2011 at 2:13 AM, Mahesh J Salgaonkar
    >> <mahesh@linux.vnet.ibm.com> wrote:
    >> >
    >> > During free we do free all of them including RMO region. But since
    >> > the rtas region is always on top of RMO, crashkernel memory overlaps
    >> > rtas region and we endup freeing that even, which is causing the
    >> > crash.
    >> >
    >> >
    >> Okay, but with this patch applied, we will just ignore rtas region,
    >> right?
    > Correct.
    >> Thus, when I echo 0 to free all the 128M crashkernel memory, the final
    >> result will be 32M left, which means crash_size will still show 32M.
    >> This looks odd.
    >>
    >> How about skipping the 32M as a whole? I mean once the region being
    >> freed has overlap with this rtas region, skip the whole rtas region,
    >> and let crash_size
    >> show 0?
    > The existing code from crash_shrink_memory() function reduces the crash
    > size to 0 when echo'ed 0. I did test this patchset and verified that
    > /sys/kernel/kexec_crash_size show 0 value.

    Oh, ok.

    Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

    Thanks.

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-21 04:13    [W:0.048 / U:0.192 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site